go.mod: github.com/lima-vm/lima/v2 #3731
Conversation
The major version is now updated to highlight the introduction of the pluggable VM driver framework. See issue 3712 Signed-off-by: Akihiro Suda <[email protected]>
|
Why do we care abut v2? Users should not be affected by this change, and nobody should import stuff from lima since it is not a library. |
In v2 we will have significant changes including breaking ones:
Notably this one will affect the users:
Rancher Desktop does that: |
|
Placing a package in
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Go module path from github.com/lima-vm/lima to github.com/lima-vm/lima/v2 to reflect a major version change that introduces a pluggable VM driver framework.
- Updates Go module definition to v2
- Updates all internal import paths to include
/v2version suffix - Updates external references like Makefile package variables and protobuf option paths
Reviewed Changes
Copilot reviewed 142 out of 142 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates module path to include /v2 version |
| pkg/**/*.go | Updates internal import paths to reference v2 module |
| cmd/**/*.go | Updates import paths in CLI commands and tools |
| *.proto | Updates protobuf go_package option to v2 path |
| hack/oss-fuzz-build.sh | Updates fuzzer package references |
| Makefile | Updates PACKAGE variable to v2 path |
| .golangci.yml | Updates linter configuration for v2 imports |
Comments suppressed due to low confidence (1)
pkg/guestagent/api/guestservice.proto:2
- The go_package option points to '/pkg/api' but should point to '/pkg/guestagent/api' based on the file location
option go_package = "github.com/lima-vm/lima/v2/pkg/api";
|
Ok, it makes sense now. Maybe we want to move most of the code to internal/ to make sure we don't break anyone when we move stuff around. The parts that other projects are using can be kept in pkg. In ramen everything is in internal/, and we have api/ and e2e/ modules that are meant to be used by other projects. |
|
Can we merge? |
The major version is now updated to highlight the introduction of the pluggable VM driver framework.
See: